Re: [Qemu-devel] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths

[Benoît Canet]

The Monday 26 May 2014 à 19:37:04 (+0200), Markus Armbruster wrote :
> Introduced in commit 5a8a30d.  Spotted by Coverity.
> 
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
>  block/qcow2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/qcow2.c b/block/qcow2.c
> index a4b97e8..a54d2ba 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1308,6 +1308,7 @@ static void qcow2_invalidate_cache(BlockDriverState 
> *bs, Error **errp)
>      options = qdict_clone_shallow(bs->options);
>  
>      ret = qcow2_open(bs, options, flags, &local_err);
> +    QDECREF(options);
>      if (local_err) {
>          error_setg(errp, "Could not reopen qcow2 layer: %s",
>                     error_get_pretty(local_err));
> @@ -1318,8 +1319,6 @@ static void qcow2_invalidate_cache(BlockDriverState 
> *bs, Error **errp)
>          return;
>      }
>  
> -    QDECREF(options);
> -
>      if (crypt_method) {
>          s->crypt_method = crypt_method;
>          memcpy(&s->aes_encrypt_key, &aes_encrypt_key, 
> sizeof(aes_encrypt_key));
> -- 
> 1.9.3
> 
> 
Reviewed-by: Benoit Canet <ben...@irqsave.net>