On Thu, 05/22 23:30, Max Reitz wrote: > Add a default common.env in case the one supposed to be emitted by > configure cannot be found. > > Signed-off-by: Max Reitz <mre...@redhat.com>
Now we can run both from in-tree build and out-of-tree build without this, which is already very good, but we need this patch to run from the source tree with an out-of-tree build. I'm not sure we really need that, though. common.env.default worries me a bit with the impression that we are guessing the configure's output when we don't know the right place to look. Not a big issue with $PYTHON itself, but it's dubious whether this file is right in its place. Let's wait for others' input. Thanks, Fam > --- > tests/qemu-iotests/common.env.default | 6 ++++++ > 1 file changed, 6 insertions(+) > create mode 100644 tests/qemu-iotests/common.env.default > > diff --git a/tests/qemu-iotests/common.env.default > b/tests/qemu-iotests/common.env.default > new file mode 100644 > index 0000000..406e1f1 > --- /dev/null > +++ b/tests/qemu-iotests/common.env.default > @@ -0,0 +1,6 @@ > +if command -v python2 > /dev/null > +then > + export PYTHON='python2' > +else > + export PYTHON='python' > +fi > -- > 1.9.3 > >
