Eric Blake <ebl...@redhat.com> writes: > On 05/11/2014 07:35 PM, Fam Zheng wrote: >> This adds the enum of all the operations that can be taken on a block >> device. >> >> Signed-off-by: Fam Zheng <f...@redhat.com> >> Reviewed-by: Benoit Canet <ben...@irqsave.net> >> Reviewed-by: Jeff Cody <jc...@redhat.com> >> --- >> include/block/block.h | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) > > Is it worth making this a formal QAPI enum, documented in the .json > file? If we ever add qapi introspection, it might be nice to know when > new block op types are added as part of the formal qapi definition.
Moving it into the schema when QAPI needs it shouldn't be hard.