On Wed, May 07, 2014 at 01:01:12PM +0200, Paolo Bonzini wrote: > Il 05/05/2014 20:33, Luiz Capitulino ha scritto: > >>+ data = object_property_get_qobject(obj, info->name, NULL); > >>+ if (!data) { > >>+ list = list->next; > >>+ continue; > > You could use object_property_print and get rid of a relatively large amount > of code.
Thanks for pointing that. But StringOutputVisitor doesn't have handlers for structs and lists like QMP countrepart so the call segfaults when used against object properties using that. ie. Unless I am missing something, I should add those handlers to the string visitor before being able to use object_property_print(), right ? > Apart from this, the patch is definitely useful.