On Tue, May 06, 2014 at 09:13:13AM +0200, Igor Mammedov wrote: > On Mon, 5 May 2014 14:20:25 +0200 > Vasilis Liaskovitis <vasilis.liaskovi...@profitbricks.com> wrote: > > On Fri, Apr 04, 2014 at 03:36:45PM +0200, Igor Mammedov wrote: > > > + if (data == 1) { > > > + /* TODO: handle device insert OST event */ > > > + } else if (data == 3) { > > > + /* TODO: handle device remove OST event */ > > > + } > > > > Are there any patches planned to report _OST notifications to upper > > management > > layers? E.g. some older patchseries implemented a queue for these > > notifications > > that could be queried with an "info memhp" command. > I don't recall seeing patches "info memhp", could you point them to me, > please? > But I have in mind to add corresponding commands for get OST and sending > corresponding QMP events.
Old patch for "info memhp" (or "info memory-hotplug") are here: http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg03539.html not sure if we want a separate command though, or have eveyrhting in "info dimm" > > > > > As a more general question for the patchseries: How do we query > > status/presence > > of dimms present? Some posssible options could be: > > > > - info qtree: If links<> are implemented between dimms and an acpi machine > > adapter, would the dimms show up in the general device tree? Currently I > > believe > > they don't. > > > > - info dimm: We could have a new "info dimm" command that shows information > > for > > present DIMMs: start-end guest physical address, last _OST notification > > received > > for this DIMM, as well as backing memdev object for this dimm. > I'd prefer this one for hmp and from QMP side qom-get could be used to > enumerate/get > properties. I also prefer "info dimm" for hmp. For qmp, how flexible is qom-get? Can we use a single qom-get command to e.g. receive properties of all dimm devices? I think a command that lists all dimm devices and properties could be useful. thanks, - Vasilis