Eric Blake writes: > On 04/30/2014 01:09 PM, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> --- >> Makefile | 24 ++++++++++++++++++------ >> tests/Makefile | 20 ++++++++++++++++---- >> 2 files changed, 34 insertions(+), 10 deletions(-) >>
>> @@ -362,7 +368,13 @@ check-tests/test-qapi.py: tests/test-qapi.py >> >> .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y)) >> $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: >> $(SRC_PATH)/%.json >> - $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts $(PYTHON) >> $(SRC_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.test.out 2>$*.test.err; >> echo $$? >$*.test.exit, " TEST $*.out") >> + $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts \ >> + $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py \ >> + <$^ \ >> + >$*.test.out \ >> + 2>$*.test.err; \ > I've already made the comment several times that I would have put these > three lines as one instead of excessively wrapping into three; I'm a bit > surprised you haven't picked up on the hint when rebasing for other > reasons. But the patch as-is is still valid, so my Reviewed-by is still > okay whether or not you have a reason to spin a v11. Sorry, forgot about that one. Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth
