[meta-comment] On 04/27/2014 11:07 PM, TeLeMan wrote: > -- > SUN OF A BEACH > > > On Tue, Oct 15, 2013 at 2:33 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> This adds C code for generating ACPI tables at runtime,
<snip ~ 50k>
>> + if (misc.has_hpet) {
>> + build_hpet(tables->table_data, tables->linker);
>> + }
>
> If no hpet, the acpi table is corrupt. The following is the corrected code:
>
> build_madt(tables->table_data, tables->linker, &cpu, guest_info);
> if (misc.has_hpet) {
> acpi_add_table(table_offsets, tables->table_data);
> build_hpet(tables->table_data, tables->linker);
> }
>
>
>> + if (guest_info->numa_nodes) {
<snip ~20k>
Hiding less than 10 lines of reply about 50k into a 70k message is not
nice. Good netiquette says that you should trim quoted portions of your
message down to the relevant part of what your reply is in reference to.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
