On Tue, Apr 8, 2014 at 10:01 PM, Chen Gang <gang.chen.5...@gmail.com> wrote:
> Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not
> need additional useless 'continue'.
>
Only in the case where the if-else is not followed by any code. Which
is the case here. I found this sentance slightly confusing and TBH id
just drop it or say something less codey like:
"This if else has no code between it and the end of the enclosing
while loop. This makes this continue redundant."
> Signed-off-by: Chen Gang <gang.chen.5...@gmail.com>
But patch is good:
Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com>
> ---
> vl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 9975e5a..7505002 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3034,7 +3034,6 @@ int main(int argc, char **argv, char **envp)
> if (argv[optind][0] != '-') {
> /* disk image */
> optind++;
> - continue;
> } else {
> const QEMUOption *popt;
>
> --
> 1.7.9.5
>
