On 31 March 2014 19:07, Tom Musta <tommu...@gmail.com> wrote: > On 3/31/2014 12:48 PM, Peter Maydell wrote: >> So, float64_to_uint64_round_to_zero() works by temporarily >> fiddling with the rounding mode and then calling >> float64_to_uint64(). Is there a reason for doing this >> function like this rather than in the same way?
> True. But not all of the *_round_to_zero() routines do this, e.g. > float32_to_int64_round_to_zero(). So no matter what I do, it is > inconsistent with something. > > Do you prefer the fiddle-and-reuse approach? (I think I do, actually). > If so, I will respin the patch. I think that would be easier to review for correctness :-) thanks -- PMM
