Stefan Hajnoczi, le Thu 20 Mar 2014 08:58:11 +0100, a écrit : > My suggestion is to split all the preparation and cleanups into a > smaller patch series that can be applied easily. > > It will make the real IPv6 series smaller and hopefully more amenable to > review.
Well, I believe it's already split that way: patches 1, 2, 3, 6, 7, 8, 9, and 11 are all one-target cleanups which can be applied independently of the rest. Patches 4, 5, 10, 12, 13, 14, 15, and 16, which actually bring IPv6 support, are then mostly only line additions (only patch13 refactors things, but needs some rework to be applied right away). The only thing I see could be separated out more is the reindentation. Samuel patch1-bugs udp.c | 1 + 1 file changed, 1 insertion(+) patch2-refactor if.c | 2 - mbuf.c | 2 - mbuf.h | 2 - slirp.c | 107 +++++++++++++++++++++++++++++++++++++--------------------------- slirp.h | 12 +++---- 5 files changed, 71 insertions(+), 54 deletions(-) patch3-timer timer.h | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) patch6-socket-refactor ip_icmp.c | 2 ++ slirp.c | 48 ++++++++++++++++++++++++++++++++++++++++-------- socket.c | 14 +++++++++++--- socket.h | 25 +++++++++++++++++++++---- tcp_input.c | 2 ++ tcp_subr.c | 2 ++ udp.c | 4 ++++ 7 files changed, 82 insertions(+), 15 deletions(-) patch7-socket-refactor2 bootp.c | 2 - ip_icmp.c | 19 ++---------- socket.c | 93 +++++++++++++++++++++++++++++++++++++++++++++++-------------- socket.h | 3 + tcp_subr.c | 24 +++------------ tftp.c | 6 +-- udp.c | 27 ----------------- udp.h | 3 - 8 files changed, 91 insertions(+), 86 deletions(-) patch8-socket-refactor3 socket.c | 30 ++++++++++++++++-------------- socket.h | 30 +++++++++++++++++++++++++++++- tcp_input.c | 27 +++++++++++---------------- udp.c | 25 ++++++------------------- 4 files changed, 62 insertions(+), 50 deletions(-) patch9-udp-refactor ip_icmp.c | 2 +- udp.c | 7 ++++--- udp.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) patch11-tcp-fconnect slirp.h | 2 +- tcp_input.c | 3 ++- tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-)
