On Tue, 2014-03-18 at 14:28 +0000, Peter Maydell wrote: > On 18 March 2014 14:27, Marcel Apfelbaum <marce...@redhat.com> wrote: > > On Tue, 2014-03-18 at 16:05 +0200, Marcel Apfelbaum wrote: > >> On Tue, 2014-03-18 at 13:57 +0000, Peter Maydell wrote: > >> > I'm confused; why doesn't this just result in a compiler > >> > error in the other direction when we try to #define > >> > MACHINE in QEMU and it's already been defined by > >> > the BSD headers? > >> Maybe because there is usage of the "MACHINE" define by the BSD > >> library? (on Qemu context, of course! - meaning, it shouldn't even be > >> exposed in the first place!) > > I meant "there is *no* usage of the..." > > But we'll still see > #define MACHINE something > and then later > #define MACHINE something-else > > right? The compiler ought to complain about that, at point > of the second #define; use or otherwise of the macro isn't > relevant here. Right! Sorry. As Andreas said in IRC, BSDs do not build with -Werror
> > thanks > -- PMM >
