On Wed, Mar 12, 2014 at 03:51:34PM +0800, Chen Fan wrote: > Signed-off-by: Chen Fan <chen.fan.f...@cn.fujitsu.com> > --- > target-i386/topology.h | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/target-i386/topology.h b/target-i386/topology.h > index 07a6c5f..9b811c1 100644 > --- a/target-i386/topology.h > +++ b/target-i386/topology.h > @@ -47,6 +47,12 @@ > */ > typedef uint32_t apic_id_t; > > +typedef struct X86CPUTopoInfo { > + unsigned pkg_id; > + unsigned core_id; > + unsigned smt_id; > +} X86CPUTopoInfo; > + > /* Return the bit width needed for 'count' IDs > */ > static unsigned apicid_bitwidth_for_count(unsigned count) > @@ -92,13 +98,11 @@ static inline unsigned apicid_pkg_offset(unsigned > nr_cores, unsigned nr_threads) > */ > static inline apic_id_t apicid_from_topo_ids(unsigned nr_cores, > unsigned nr_threads, > - unsigned pkg_id, > - unsigned core_id, > - unsigned smt_id) > + X86CPUTopoInfo *topo)
topo could be const X86CPUTopoInfo*, but not a big deal. Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo