On 03/11/2014 08:09 AM, Leandro Dorileo wrote: > Hi Kevin, > > On Tue, Mar 11, 2014 at 12:06:16PM +0100, Kevin Wolf wrote: >> Am 08.03.2014 um 19:47 hat Leandro Dorileo geschrieben: >>> The following patchset introduces a general purpose argument parser and >>> migrates >>> qemu-img to make use of it. qemu-img is just the first user of it, if we >>> see a >>> good feedback here I move forward and migrate all the other possible users. >> >> I was planning to reply to this in more detail, but it doesn't look like >> I can find the time to do so, so let me just summarise my thoughts >> briefly. > > Ok. > >> >> I do like the idea of simplifying qemu-img's argument parsing, but we >> shouldn't make the mistake of introducing another option parsing >> infrastructure and end up with three different coexisting models. If we >> were to introduce a new framework, we must make sure that all code is >> converted to it and QemuOpts can be dropped. > > Agreed.
For that matter, if you want to help the current conversion efforts going on, we are trying to get rid of QEMUOptionParameters to _just_ use QemuOpts: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg01728.html >> >> We would probably need to add a new parser to QemuOpts that parses >> command line options into a QemuOpts, and extend the definition of them >> with a couple of new features that are required there (sub-QemuOpts for >> -o, perhaps enumerations for things like --output=human/json, positional >> parameters). > > Ok. We also need to think how to expose those improvements via the QMP command query-command-line-arguments; lots of details in this thread: https://lists.gnu.org/archive/html/qemu-devel/2014-03/threads.html#00934 -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
