On Thu, Feb 13, 2014 at 05:22:33PM +0100, Benoît Canet wrote: > As bdrv_open() documentation states: > "The reference to the QDict belongs to the block layer > * after the call (even on failure), so if the caller intends to reuse the > * dictionary, it needs to use QINCREF() before calling bdrv_open." > > the optional options dict will not be reused after bdrv_open() and should > belong to the block layer so remove the extra QDECREF(options). > > Signed-off-by: Benoit Canet <ben...@irqsave.net> > --- > blockdev.c | 2 -- > 1 file changed, 2 deletions(-)
Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan