This extra QDECREF() was causing quorum_close() to crash while doing bdrv_unref().
As the optional options qdict should belong to the block layer so do not use QDECREF() on it. I tested the following inti and qemu exit sequences. tested regular snapshots on device=virtio0 ok tested command line quorum ok tested command line quorum + snapshot transaction ok tested quorum open by reference ok tested quorum open by reference + snapshot transaction ok tested quorum open at once ok tested quorum open at once + snapshot transaction ok Benoît Canet (1): blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close. blockdev.c | 2 -- 1 file changed, 2 deletions(-) -- 1.8.3.2