I post this for review in prevision of 2.0 feature freeze.
Even if the series look correct please wait before merging because:
The QMP events in the "Add quorum mechanism" definitively needs to be reviewed
by Eric as they where changed.
I did not found any bugs while testing this version but I am willing to test the
code further before it's applied even it's reviewed by.
Best regards
Benoît
v17:
minor comment cleanup requested by kevin in quorum_open [Kevin]
better handling of qdict in quorum_open (avoid a crash on exit) [Benoît]
remove uneeded NULL assigment on close [Benoît]
rename QuorumChildRequest variables [Benoît]
in v16:
fix unaligned comment [Benoît]
s/QuorumSingleAIOCB/QuorumChildRequest/ [Kevin]
s/total/num_children/ [Kevin]
Remove QuourmAIOCB finished field as bdrv_aio_cancel is now used [Benoît]
fix typedef struct [Kevin]
Document blkverify mode [Kevin]
s/callback/callbacks/ [Kevin]
free data structures on quorum_aio_cancel [Kevin]
drop bqs [Kevin]
replace acb->bqs usage by acb->common.bs->opaque [Kevin]
fix compilation error on patch 3 [Kevin]
better document qemu_iovec_compare [Kevin]
don't zero structure intended to be freed [Kevin]
Do simple if [Kevin]
merge for loops [Kevin]
s/bs->file/s->bs[i]/ [Kevin]
pass individual qiov to read one patch sooner [Kevin]
remove uneeded forward declaration [Kevin]
simplify compare function [Kevin]
initialize vote list at the right place [Kevin]
node_name should not be NULL assert it [Kevin]
s/i/max/g in get_vote_winner [Kevin]
document why quorum_iovec_compare exists [Kevin]
convert comment into assert [Kevin]
set quorum default to true [Kevin]
simplify quorum success condition after max addition quorum_vote test
[Benoît]
remove uneeded test after vote [Kevin]
change comment on quorum failure searching [Benoît]
introduce reference in QUORUM_FAILURE [Kevin]
remove unneeded KEY_ defines [Benoît]
Use QemuOptList to shorten code [Kevin]
remove uneeded includes [Benoît]
fill authorization table [Benoît]
extract quorum_has_too_much_io_failed [Benoît]
call this function when not reading [Benoît]
report error on io failure [Benoît]
!! need Eric review
don't flush on exit [Kevin]
Benoît Canet (12):
quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB.
quorum: Create BDRVQuorumState and BlkDriver and do init.
quorum: Add quorum_aio_writev and its dependencies.
blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from
blkverify.
quorum: Add quorum_aio_readv.
quorum: Add quorum mechanism.
quorum: Add quorum_getlength().
quorum: Add quorum_invalidate_cache().
quorum: Add quorum_co_flush().
quorum: Implement recursive .bdrv_recurse_is_first_non_filter in
quorum.
quorum: Add quorum_open() and quorum_close().
quorum: Add unit test.
block/Makefile.objs | 1 +
block/blkverify.c | 108 +-----
block/quorum.c | 867 +++++++++++++++++++++++++++++++++++++++++++++
configure | 36 ++
docs/qmp/qmp-events.txt | 36 ++
include/monitor/monitor.h | 2 +
include/qemu-common.h | 2 +
monitor.c | 4 +
qapi-schema.json | 21 +-
tests/qemu-iotests/081 | 95 +++++
tests/qemu-iotests/081.out | 34 ++
tests/qemu-iotests/group | 1 +
util/iov.c | 106 ++++++
13 files changed, 1206 insertions(+), 107 deletions(-)
create mode 100644 block/quorum.c
create mode 100755 tests/qemu-iotests/081
create mode 100644 tests/qemu-iotests/081.out
--
1.8.3.2
