On Thu, 17 Dec 2009, Richard Henderson wrote:

;;
+ sh4)
+ cpu="sh4"
+ ;;

You don't need this entry. That table is supposed to be for changing the name. You'd use it if uname returned sh4eb though...

Indeed, I got swayed. Then also "m68k" and "i386" are superfluous there.

As for sh4eb, AFAIK "uname -m" still returns "sh4" only. This leaves us in a situation similar to mips and arm - we could still want to have qemu for the other endianness.

On a side note, why is the mask for e_type 0xfffe, allowing both ET_EXEC and ET_DYN? I.e. when would we need it for shared libraries?

Being new here - what should I do about the patch? Send again, with fixes?

Best regards,

David


Reply via email to