Re: [Qemu-devel] [PATCH 6/8] target-arm: A64: Add integer ops from SIMD 3-same group

[Xbing Wang]

Making them static makes this function NOT thread-safe (and they're 
hidden in thousands of lines of codes), there will be boys who want the 
whole file translate-a64.c to be thread-safe. What do you think?

Thanks.
- xbing
On 01/22/2014 03:53 AM, Peter Maydell wrote:
On 21 January 2014 19:37, Richard Henderson <r...@twiddle.net> wrote:
On 01/17/2014 10:44 AM, Peter Maydell wrote:
+                NeonGenFn *ceqtstfns[3][2] = {
You want all of these arrays to be static and const:

   static NeonGenFn * const ceqtstfns[3][2] = ...
I confess I couldn't figure out the right place to
put the 'const' to placate the compiler :-)

thanks
-- PMM