12.01.2014 23:07, Peter Maydell wrote: > On 11 January 2014 09:34, <pavel.zbits...@gmail.com> wrote: >> From: Pavel Zbitskiy <pavel.zbits...@gmail.com> >> >> optlen parameter of getsockopt() of type socklen_t* was read into >> variable of type socklen_t, that caused zeroing out of upper 4 bytes >> when running s390x on top of x86_64. This patch changes optlen type >> to abi_ulong. > > This patch and patch 3 are correct fixes, but shouldn't we be > more generally using abi_ulong for every argument we read from > the guest in do_socketcall() ?
I think the current fix is worth to apply anyway, regareless of further possible rework. Thanks, /mjt
