Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns

[Richard Henderson]

On 12/17/2013 07:12 AM, Peter Maydell wrote:
> +    tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2);
> +    if (is_sub) {
> +        tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> +    } else {
> +        tcg_gen_add_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> +    }

Perhaps worth noticing the RA=XZR special case for the MUL alias?

Otherwise,

Reviewed-by: Richard Henderson <r...@twiddle.net>


r~