On 15 December 2013 18:51, Andreas Färber <afaer...@suse.de> wrote: > Am 15.12.2013 05:10, schrieb Anthony Green: >> This patch still needs to be applied. There was some follow-up >> discussion on this patch back in May, but none of it negates the fact >> that this patch needs to be applied. > > It introduces a tab, please fix. > > Apart from that I believe I reported some inconsistencies between > targets in that function, so "all targets except moxie do it conditional > to FOO" may be a convincing explanation independent of the bug you were > discussing that may or may not be otherwise workaroundable.
I dug out the thread where you did that (which turns out to be private mail and not qemu-devel). In follow up to that RTH and I agreed that it definitely is a bug and this patch is the correct fix. > And since this is purely in target-moxie I would suggest to simply send > a pull as target maintainer once you have someone trustworthy's > Reviewed-by and it doesn't break `make check`, similar to how it's done > for OpenRISC. Yes, this makes sense to me, especially since Anthony has a number of other moxie patches on list at this point. thanks -- PMM
