Hi, Am 15.12.2013 05:10, schrieb Anthony Green: > > This patch still needs to be applied. There was some follow-up > discussion on this patch back in May, but none of it negates the fact > that this patch needs to be applied.
It introduces a tab, please fix. Apart from that I believe I reported some inconsistencies between targets in that function, so "all targets except moxie do it conditional to FOO" may be a convincing explanation independent of the bug you were discussing that may or may not be otherwise workaroundable. And since this is purely in target-moxie I would suggest to simply send a pull as target maintainer once you have someone trustworthy's Reviewed-by and it doesn't break `make check`, similar to how it's done for OpenRISC. And as usual the warning that I have a patch lying around that changes the cpu_loop_exit() argument to CPUState, but I may not get to rebasing that until the holidays, so no imminent conflict. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
