On Thu, Dec 10, 2009 at 08:04:56PM +0200, Michael S. Tsirkin wrote:
> On Thu, Dec 10, 2009 at 03:22:52PM +0200, Gleb Natapov wrote:
> > On Thu, Dec 10, 2009 at 02:23:05PM +0200, Michael S. Tsirkin wrote:
> > > On Thu, Dec 10, 2009 at 01:19:10PM +0100, Gerd Hoffmann wrote:
> > > > Hi,
> > > >
> > > >>> + if (pci_dev == NULL) {
> > > >>> + hw_error("PCI: can't register device\n");
> > > >>> + }
> > > >>
> > > >> Can you please use !pci_dev for these checks?
> > > >
> > > > Why? IMHO the code is more readable that way. It is easy to miss a
> > > > single '!' character when reading the code, so I tend to write such
> > > > tests in a more verbose fashion.
> > > >
> > > > cheers,
> > > > Gerd
> > >
> > > Reader has limited short term memory. Don't fill it up with
> > > irrelevant detail. In places where it might be confusing,
> > > a comment might be appropriate, this is not one of them.
> > >
> > > C is a terse language. !x is a standard idiom. Let's use it.
> > >
> > ! is for boolean.
>
> In which language? Not in C.
>
In boolean. My point is no need to force your style on everyone if it is
not in coding style document. == often much more readable then !.
> > pci_dev is not boolean.
> > --
> > Gleb.
--
Gleb.
