On 07.12.2009, at 15:39, Gerd Hoffmann wrote: > On 12/07/09 15:07, Alexander Graf wrote: >> >> On 07.12.2009, at 14:27, Gerd Hoffmann wrote: >> >>>> Default variables belong in the machine description IMHO. On >>>> S390, we can't create serial, parallel or vga (or any MMIO/PIO >>>> requiring) devices. >>> >>> See last patch of this series. Moving that into the machine >>> description is certainly worth looking at. For now I'm happy that >>> the #ifdef S390 code for the default virtio console is down to just >>> two lines. >> >> Would it be that hard to move the list of default devices to the >> machine description? You could probably still keep the default_xxx >> variables in vl.c, but access them from e.g. pc.c. > > > Hmm? access from pc.c? What exactly do you have in mind? > > > I think we could add flags to QEMUMachine to disable default devices not > supported anyway, i.e. add no_parallel variable, then in vl.c do > > if (machine->no_parallel) > default_parallel = 0; > > So qemu would stop creating a useless parallel0 chardev which isn't used > because the machine in question can't support parallel ports anyway.
Well I was basically thinking of moving default_list inside the machine description. That way you can easily choose what default devices there are available. Then make default_serial and friends visible to pc.c and just put the same code you have now in there. For other machines the default device list surely looks different. Alex
