On 07.12.2009, at 13:42, Gerd Hoffmann wrote: > Qemu creates a default serial line for you in case you didn't specify > one on the command line. Right now this is tied to the '-serial > <chardev>' command line switch, which in turn causes trouble if you are > creating your serial line via '-device isa-serial,<props>'. > > This patch adds a variable default_serial which says whenever a default > serial line should be added. It is enabled by default. It is cleared > when qemu finds '-serial' or '-device isa-serial' on the command line. > > Part of the patch is some infrastructure for the '-device $driver' > checking (default_driver_check function) which will also be used by the > other patches of this series. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > vl.c | 122 +++++++++++++++++++++++++++++++++++++++++++---------------------- > 1 files changed, 81 insertions(+), 41 deletions(-) > > diff --git a/vl.c b/vl.c > index 24d5d92..eca4eee 100644 > --- a/vl.c > +++ b/vl.c > @@ -271,6 +271,30 @@ uint8_t qemu_uuid[16]; > static QEMUBootSetHandler *boot_set_handler; > static void *boot_set_opaque; > > +static int default_serial = 1;
Default variables belong in the machine description IMHO. On S390, we can't create serial, parallel or vga (or any MMIO/PIO requiring) devices. Alex
