Am 05.09.2013 14:54, schrieb Alexander Graf: > > On 01.08.2013, at 16:12, Jason J. Herne wrote: > >> From: "Jason J. Herne" <jjhe...@us.ibm.com> >> >> Latest code for cpu Hotplug on S390 architecture. This one is vastly >> simpler >> than v2 as we have decided to avoid the command line specification >> of -device s390-cpu. >> >> The last version can be found here: >> http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01183.html >> >> There is also a patch in this series to add cpu-add to the Qemu monitor >> interface. >> >> Hotplugged cpus are created in the configured state and can be used by the >> guest after the guest onlines the cpu by: >> "echo 1 > /sys/bus/cpu/devices/cpuN/online" >> >> Hot unplugging is currently not implemented by this code. > > Very simple and clean patch set. I don't think it deserves the RFC tag.
Negative, see my review. If you want to fix up and queue patches 1-2 that's fine with me, but the others need a respin. No major blocker though, just some more footwork mostly related to QOM and Jason's shifted focus on cpu-add rather than device_add. Open issues: * Might ipi_states need to become a device due to migration? * QOM properties considerations * Device creation in qdev initfn * Parent field access * QOM-unfriendly creation and reliance upon helper function Andreas > > Apart from the minor comments I had consider it > > Reviewed-by: Alexander Graf <ag...@suse.de> > > > Alex > -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
