Am 03.09.2013 um 10:09 hat Max Reitz geschrieben: > > This series adds support to qemu-img, block and qcow2 for amending image > options on existing image files. > > Depends on: > - option: Add assigned flag to QEMUOptionParameter > - qcow2-refcount: Snapshot update for zero clusters (series, v3) > - Add metadata overlap checks (series, v5) > > v5: > - added a new function for emptying a cache (patch 2) > - fixed rounding for the bitmap size in qcow2_expand_zero_clusters > - now empties the cache in qcow2_expand_zero_clusters instead of simply > flushing it > - factored out assignment check in qcow2_amend_options > - fixed resizing by moving it to the end of qcow2_amend_options > - fixed expected test result for resizing in addition to a version > upgrade
There's still room for improvements on top, in particular the additional test cases I suggested in the v4 thread and the real qcow2_truncate() fix that is just worked around here by moving its call (it needs to update bs->total_sectors), but this looks good enough to be merged now. Reviewed-by: Kevin Wolf <kw...@redhat.com>
