On Mon, Sep 02, 2013 at 05:18:10PM +0800, Wenchao Xia wrote: > This series add test case for fd passing with unix socket at runtime. Since > getfd and closefd interface will interact with monitor's data, so it will > help to do regression test for monitor patches. Since python2 do not support > sendmsg(), so a C helper program is added to do the job. > > v2: > 1: add missing $ in the makefile rule. > > v3: > Address Eric's comments: > 1: typo fix, remove "." in the end of error message, strick > check argc as "!=", use EXIT_SUCCESS and EXIT_FAILURE as exit > values, strict error check for strtol() call. > Address Luiz's comments: > 1: change the helper program parameter as "bin < socket-fd > < file-path >", > the program open the file itself now, data parameter is removed and blank > is always used as iov data, better usage tip message, folder the string > parsing > code into a function. > 2: related change for helper program parameter change. > 3: related change for helper program parameter change. > Other: > 1: remove "LINK" rule in makefile, remove fd checking code inside send_fd() > since it is already checked before calling, add '' around %s for path and > number string in error message. > 2: renamed fd_bin to bin in send_fd_scm() to tip better, add '' around %s > for path in error message. > > Wenchao Xia (3): > 1 qemu-iotests: add unix socket help program > 2 qemu-iotests: add infrastructure of fd passing via SCM > 3 qemu-iotests: add tests for runtime fd passing via SCM rights > > QMP/qmp.py | 6 ++ > configure | 2 +- > tests/Makefile | 3 +- > tests/qemu-iotests/045 | 36 ++++++++- > tests/qemu-iotests/045.out | 4 +- > tests/qemu-iotests/check | 1 + > tests/qemu-iotests/iotests.py | 23 ++++++ > tests/qemu-iotests/socket_scm_helper.c | 135 > ++++++++++++++++++++++++++++++++ > 8 files changed, 205 insertions(+), 5 deletions(-) > create mode 100644 tests/qemu-iotests/socket_scm_helper.c
Looks useful. I have left comments about whitespace cleanups and requested a few additional tests for addfd/getfd/closefd errors.
