On 08/30/2013 04:39 PM, Paolo Bonzini wrote: > Il 30/08/2013 08:15, Alexey Kardashevskiy ha scritto: >>>> What if you just merge the two series together? >> It will still be a function which can accept sections bigger than 2^64 and >> theoretically call int128_get64() and assert. I would think that every time >> when anyone calls int128_get64(), the value should be checked for <2^64. It >> is like division by zero :) > > I understood that int128_get64() would be called only for RAM sections, > not for IOMMUs (and RAM sections cannot be 2^64-bytes large). Is this > wrong?
This is correct but for people who do not know when and in what state it is called, it can be confusing. Ok, I'll merge this with my vfio patches. -- Alexey