Am 23.08.2013 18:01, schrieb arm...@redhat.com: > From: Markus Armbruster <arm...@redhat.com> > > scsi_bus_legacy_add_drive() creates either a scsi-disk or a > scsi-generic device. It sets property "serial" to argument serial > unless null. Crashes with scsi-generic, because it doesn't have such > the property. > > Only usb_msd_initfn_storage() passes non-null serial. Reproducer: > > $ qemu-system-x86_64 -nodefaults -display none -S -usb \ > -drive if=none,file=/dev/sg1,id=usb-drv0 \ > -device usb-storage,id=usb-msd0,drive=usb-drv0,serial=123 > qemu-system-x86_64: -device > usb-storage,id=usb-msd0,drive=usb-drv0,serial=123: Property '.serial' not > found > Aborted (core dumped) > > Fix by handling exactly like "removable": set the property only when > it exists. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/scsi/scsi-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas Färber <afaer...@suse.de> Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
