----- Original Message ----- > From: "Kevin Wolf" <kw...@redhat.com> > To: "Paolo Bonzini" <pbonz...@redhat.com> > Cc: qemu-devel@nongnu.org, stefa...@redhat.com, ebl...@redhat.com, > p...@kamp.de > Sent: Wednesday, July 31, 2013 11:12:27 AM > Subject: Re: [PATCH v3 18/19] block: add default get_block_status > implementation for protocols > > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > > Protocols return raw data, so you can assume the offsets to pass > > through unchanged. > > > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > Not really objecting, but is this useful? > > In formats, BDRV_BLOCK_OFFSET_VALID means that the given offset is valid > for bs->file, which is something that protocols simply don't have. You > can do it like you do here, but actually this information is redundant. > > Do you make use of it for anything?
It is used by format=raw. I could do it in raw.c, but some protocols are opened directly without the "raw" veneer on top. Paolo
