Am 28.07.2013 14:55, schrieb Paolo Bonzini: > Il 28/07/2013 14:45, Andreas Färber ha scritto: >> Am 28.07.2013 14:35, schrieb Paolo Bonzini: >>> diff --git a/trace-events b/trace-events >>> index 002df83..3e0dd74 100644 >>> --- a/trace-events >>> +++ b/trace-events >>> @@ -1165,6 +1165,10 @@ kvm_vm_ioctl(int type, void *arg) "type %d, arg %p" >>> kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, >>> arg %p" >>> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d" >>> >>> +# memory.c >>> +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsigned >>> size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d" >>> +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsigned >>> size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d" >> >> %u would seem more correct for unsigned - if you fix that, Reviewed-by: >> Andreas Färber <afaer...@suse.de> and ACK that's it's good for 1.6. > > Ok, though it can only be 1/2/4/8.
I had static analysis in mind. ;) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
