Hi Max, Am 06.07.2013 20:01, schrieb Max Filippov: > On Sat, Jul 6, 2013 at 4:55 PM, Andreas Färber <afaer...@suse.de> wrote: >> Am 29.06.2013 22:01, schrieb Andreas Färber: >>> Register a CPU type per core registered. Save the XtensaConfig in >>> XtensaCPUClass instead of CPUXtensaState. >>> >>> Prepares for storing per-class GDB register count. >>> >>> Signed-off-by: Andreas Färber <afaer...@suse.de> >> >> Ping! Can you ack? (It did not seem to break your test image.) > > I tried make check -C tests/tcg/xtensa with the branch you recommended > and it segfaults on elf loading:
That's weird, I'm seeing a similar breakage with the test image on today's qom-cpu-11 branch. It is not caused by this commit though, so must be something I reordered last minute... sorry. The make command above was not working, I've sent a patch for out-of-tree builds and to update it to the current tree layout with tcg/ subdirectory. Andreas > #0 object_class_dynamic_cast_assert (class=0x0, > typename=typename@entry=0x55555573a85e "cpu", > file=file@entry=0x5555557349c8 > "/home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/include/qom/cpu.h", > line=line@entry=290, func=func@entry= > 0x555555735770 <__func__.17127> "cpu_get_phys_page_debug") at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/qom/object.c:535 > #1 0x00005555556b884b in cpu_get_phys_page_debug (addr=3489660928, > cpu=0x555556275a30) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/include/qom/cpu.h:290 > #2 translate_phys_addr (env=0x555556275a30, addr=3489660928) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/hw/xtensa/xtensa_sim.c:37 > #3 0x0000555555602b9b in load_elf32 (clear_lsb=0, elf_machine=94, > highaddr=0x0, lowaddr=0x7fffffffd3b0, pentry=0x7fffffffd3a8, > must_swab=<optimized out>, translate_opaque=0x555556275a30, > translate_fn= > 0x5555556b8800 <translate_phys_addr>, fd=10, name=0x555556267df0 > "./test_b.tst") at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/include/hw/elf_ops.h:269 > #4 load_elf (filename=filename@entry=0x555556267df0 "./test_b.tst", > translate_fn=translate_fn@entry=0x5555556b8800 <translate_phys_addr>, > translate_opaque=translate_opaque@entry=0x555556275a30, > pentry=pentry@entry= > 0x7fffffffd3a8, lowaddr=lowaddr@entry=0x7fffffffd3b0, > highaddr=highaddr@entry=0x0, big_endian=big_endian@entry=0, > elf_machine=elf_machine@entry=94, clear_lsb=clear_lsb@entry=0) > at /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/hw/core/loader.c:326 > #5 0x00005555556b8a23 in xtensa_sim_init (args=<optimized out>) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/hw/xtensa/xtensa_sim.c:94 > #6 0x000055555559cf6f in main (argc=<optimized out>, argv=<optimized > out>, envp=<optimized out>) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/vl.c:4286 > > The mainline is ok. > -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
