On 06/24/2013 07:48 PM, Stefan Weil wrote:
i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports this warning:hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void function [-Wreturn-type] Adding a default case to the switch statement satisfies the compiler. This modification requires moving the assert statement. Signed-off-by: Stefan Weil<s...@weilnetz.de> --- hw/ppc/spapr_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 04e8362..c04086c 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -448,9 +448,10 @@ static uint64_t spapr_io_read(void *opaque, hwaddr addr, case 2: return cpu_inw(addr); case 4: + default: + assert(size == 4); return cpu_inl(addr);
Please fix this one up with g_assert_not_reached() as well. Alex
