Kevin Wolf <kw...@redhat.com> writes: > Am 23.06.2013 um 23:39 hat Anthony Liguori geschrieben: >> Kevin Wolf <m...@kevin-wolf.de> writes: >> >> > Kevin Wolf (3): >> > multiboot: Don't forget last mmap entry >> > multiboot: Calculate upper_mem in the ROM >> > multiboot: Updated ROM binary >> >> Reviewed-by: Anthony Liguori <aligu...@us.ibm.com> >> >> Do you have a test case that triggered this that you can share? > > I haven't seen an actual kernel failure myself, this was reported by > someone else. But it's easy enough to check with a simple Multiboot > kernel that just outputs lower_mem/upper_mem and the mmap. > > For debugging and fixing I added some throw-away debug code to an > existing kernel and compared the fixed version with the output when > loaded by GRUB and it matches now. > > If we can have a real test case for this somewhere, I can write a small > kernel to do the check. Not sure where it would fit though - probably > kvm-unittests is the closest, even though the test wouldn't really have > anything to do with KVM.
We could put it in pc-bios even with just a README for now. Would be nice to figure out ways to test -kernel as we do find issues often enough. It's up to you. If you had something handy, I was going to add it to my local test setup. Regards, Anthony Liguori > >> I'll apply this after a day or so when others have had a chance to review. > > Sounds good, thanks. > > Kevin
