Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data

[Dave Jones]

On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
 
 > >    pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
 > > +  if (vi->mergeable_rx_bufs)
 > > +          hdr_len = sizeof hdr->mhdr;
 > > +  else
 > > +          hdr_len = sizeof hdr->hdr;
 > 
 > All conditionals need braces.
 
Documentation/CodingStyle disagrees:

 "Do not unnecessarily use braces where a single statement will do."
 
        Dave