On 04/26/2013 09:34 PM, Wenchao Xia wrote: >>> to find the snapshot, instead once, so matching sequence may change >>> if there are unwisely chosen, mixed id and names. >>> 2) In do_savevm(), same with del_existing_snapshot(), when it tries to >>> find the snapshot to overwrite, matching sequence may change for same >>> reason. >>> 3) In load_vmstate(), first when it tries to find the snapshot to be >>> loaded, >>> sequence may change for the same reason of above. Later in >>> validation, the >>> logic is changed to be more strict to require both id and name matching. >>> 4) In do_info_snapshot(), in validation, the logic is changed to be more >>> strict to require both id and name matching. >> >> It's easy to avoid changing semantics: keep the old name or id behavior >> around. Use the new name-and-id behavior for #3 and #4. > You mean adding a new function, instead of change > bdrv_find_snapshot()?
That's certainly an option. Although after Pavel's proposed series for adding QMP counterpart to savevm, there are no longer any uses of the old semantics. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
