On 04/12/2013 02:48 PM, Kevin Wolf wrote: > This is only to convert the internal interface that is used for passing > the "filename" to be parsed, but converting to actual fine grained > options is left for another day, as it doesn't look trivial. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/gluster.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > + > +static int qemu_gluster_open(BlockDriverState *bs, const char *dummy, > QDict *options, int bdrv_flags)
As long as you are touching this code, should you re-indent the second line of this signature? > + > + filename = qemu_opt_get(opts, "filename"); > + > > s->glfs = qemu_gluster_init(gconf, filename); Why the two blank lines? Comments deal only with whitespace, so feel free to add: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
