Am 15.04.2013 16:33, schrieb KONRAD Frédéric: > On 15/04/2013 15:34, Andreas Färber wrote: >> Am 14.04.2013 15:01, schrieb fred.kon...@greensocs.com: >>> From: KONRAD Frederic <fred.kon...@greensocs.com> >>> >>> As the virtio-rng-pci and virtio-rng-s390 are switched to the new API, >> and virtio-rng-ccw ;) >> >>> we can use QOM casts. >>> >>> Signed-off-by: KONRAD Frederic <fred.kon...@greensocs.com> >>> --- >>> hw/virtio/virtio-rng.c | 31 +++++++++++++++++-------------- >>> include/hw/virtio/virtio-rng.h | 2 +- >>> 2 files changed, 18 insertions(+), 15 deletions(-) >> Thanks, >> >> Reviewed-by: Andreas Färber <afaer...@suse.de> >> >> I was surprised to see FOO(opaque) since we usually try to avoid it for >> performance reasons, but it's not forbidden either. > True, I had taken that in account but forget this series :/. > > Is it better to change that?
I didn't spot an obvious issue, but you know the code better than me and should take a second look: load/save hooks should be no problem, but there were some opaques I didn't know where they are coming from. Andreas > > Thanks, > Fred >> Also, leaving the variable name as "s" would've spared a few lines but >> so what. :) >> >> Regards, >> Andreas >> > -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
