Re: [Qemu-devel] [PATCH] tpm: Fix several compiler warnings (redefined data types)

[Stefan Berger]

On 04/02/2013 04:14 PM, Stefan Weil wrote:

What compiler and options did you use?

Signed-off-by: Stefan Weil <s...@weilnetz.de>

Reviewed-by: Stefan Berger <stef...@linux.vnet.ibm.com>

---
  tpm/tpm_int.h |    9 ++-------
  tpm/tpm_tis.h |    4 ++--
  2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/tpm/tpm_int.h b/tpm/tpm_int.h
index b4787ad..340bfd5 100644
--- a/tpm/tpm_int.h
+++ b/tpm/tpm_int.h
@@ -15,11 +15,8 @@
  #include "exec/memory.h"
  #include "tpm/tpm_tis.h"

-struct TPMDriverOps;
-typedef struct TPMDriverOps TPMDriverOps;
-
  /* overall state of the TPM interface */
-typedef struct TPMState {
+struct TPMState {
      ISADevice busdev;
      MemoryRegion mmio;

@@ -32,12 +29,10 @@ typedef struct TPMState {

      char *backend;
      TPMBackend *be_driver;
-} TPMState;
+};

  #define TPM(obj) OBJECT_CHECK(TPMState, (obj), TYPE_TPM_TIS)

-typedef void (TPMRecvDataCB)(TPMState *, uint8_t locty);
-
  struct TPMDriverOps {
      enum TpmType type;
      /* get a descriptive text of the backend to display to the user */
diff --git a/tpm/tpm_tis.h b/tpm/tpm_tis.h
index 0c8df80..7f216e5 100644
--- a/tpm/tpm_tis.h
+++ b/tpm/tpm_tis.h
@@ -35,10 +35,10 @@
  #define TYPE_TPM_TIS                "tpm-tis"


-typedef struct TPMSizedBuffer {
+struct TPMSizedBuffer {
      uint32_t size;
      uint8_t  *buffer;
-} TPMSizedBuffer;
+};

  typedef enum {
      TPM_TIS_STATE_IDLE = 0,