Am 05.03.2013 um 10:21 hat Stefan Hajnoczi geschrieben: > On Tue, Mar 05, 2013 at 03:11:48PM +0800, Wenchao Xia wrote: > > 于 2013-3-4 21:02, Stefan Hajnoczi 写道: > > >On Fri, Mar 01, 2013 at 09:51:53AM +0800, Wenchao Xia wrote: > 于 2013-2-28 > > >0:22, Kevin Wolf 写道: > > >>Hi, Stefan > > >> Do you also agree about adding new file block/snapshot.c? > > > > > >Yes, I agree. > > > > > >Stefan > > > > > great. Also there are some other functions such as image info > > collecting, do you think new file block/misc.c is suitable > > to store those functions there? > > As discussed on IRC, it's fine by me. If a better way to organize these > functions becomes clear in the future they can be moved.
As also discussed on IRC, I'm not excited by having a block/misc.c. We already have something for "everything block related that doesn't fit elsewhere" and it's block.c. I couldn't tell if a function belong into block.c or block/misc.c. I suggested having a file that concentrates all function related to QAPI, the monitor and JSON (including the qemu-img JSON output) and call it something like block/qapi.c (I'm open for better suggestions). This would at least make it clear if a function should be in there or not. Kevin
