Am 22.02.2013 18:20, schrieb Markus Armbruster:
> Covers only PC so far.
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Andreas Färber <afaer...@suse.de>
> +static void test_cmos_byte(int reg, int expected)
> +{
> + int actual;
> +
> + outb(0x70 + 0, reg);
> + actual = inb(0x71);
Did you intend to use 0x70 + 1 here or why the 0x70 + 0 above?
> + g_assert_cmphex(actual, ==, expected);
> +}
> +int main(int argc, char *argv[])
> +{
> + g_test_init(&argc, &argv, NULL);
> +
> + qtest_add_func("boot-order/pc", test_pc_boot_order);
> +
> + return g_test_run();
> +}
So this is suggesting to me to add separate test functions per arch.
Fine with me, we'll only have to reindent one line then.
Thanks for the changes,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
