Markus Armbruster <arm...@redhat.com> writes:
> Kevin Wolf <kw...@redhat.com> writes:
>
>> On Mon, Feb 18, 2013 at 05:56:57PM -0600, Anthony Liguori wrote:
>>> GTK won't build with strict-prototypes due to gtkitemfactory.h:
>>>
>>> /* We use () here to mean unspecified arguments. This is deprecated
>>> * as of C99, but we can't change it without breaking compatibility.
>>> * (Note that if we are included from a C++ program () will mean
>>> * (void) so an explicit cast will be needed.)
>>> */
>>> typedef void (*GtkItemFactoryCallback) ();
>>>
>>> Signed-off-by: Anthony Liguori <aligu...@us.ibm.com>
>>> ---
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index bf5970f..74d5878 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -283,7 +283,7 @@ sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
>>> # default flags for all hosts
>>> QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
>>> QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes
>>> $QEMU_CFLAGS"
>>> -QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
>>> +QEMU_CFLAGS="-Wredundant-decls $QEMU_CFLAGS"
>>> QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
>>> $QEMU_CFLAGS"
>>> QEMU_INCLUDES="-I. -I\$(SRC_PATH) -I\$(SRC_PATH)/include"
>>> if test "$debug_info" = "yes"; then
>>
>> Other places wrap the inclusion of problematic headers in '#pragma GCC
>> diagnostic ...' instead of globally disabling warnings.
>
> I'd hate to lose -Wstrict-prototypes globally.
This goes away in GTK3 which a lot of people already have. I don't want
to do it in this series but I will add GTK3 support and detecting it via
configure. If we can use GTK3 instead of GTK2, we can avoid disabling
this warning.
I need to update my laptop to a newer distro first as I haven't yet made
the Gnome 3 plunge...
Regards,
Anthony Liguori
