"opp->nb_irqs-1" would have been a minor coding style error, but putting in one space but not the other makes it look confusingly like a numeric literal "-1".
Signed-off-by: Scott Wood <scottw...@freescale.com> --- hw/openpic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index c0c4307..debd77d 100644 --- a/hw/openpic.c +++ b/hw/openpic.c @@ -433,8 +433,8 @@ static void openpic_reset(DeviceState *d) opp->glbc = GLBC_RESET; /* Initialise controller registers */ - opp->frep = ((opp->nb_irqs -1) << FREP_NIRQ_SHIFT) | - ((opp->nb_cpus -1) << FREP_NCPU_SHIFT) | + opp->frep = ((opp->nb_irqs - 1) << FREP_NIRQ_SHIFT) | + ((opp->nb_cpus - 1) << FREP_NCPU_SHIFT) | (opp->vid << FREP_VID_SHIFT); opp->pint = 0; -- 1.7.9.5