On Tue, 11 Dec 2012 05:12:29 +0000 Dietmar Maurer <diet...@proxmox.com> wrote:
> Can't we enable stat queries by default (10s interval), I'm not sure I like this for two reasons. First, there will be cases where the user doesn't want this to be enabled. Second, we'll be forcing an interval on users. > and simply return all stats with one API call (query-ballon)? We can't use query-balloon because this changes query-balloon from synchronous to asynchronous, and this is an incompatible change. Now, adding a new command to do this was my first proposal on this: http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg00983.html But Anthony suggested doing this through qom, which I agree that is a simpler & cleaner interface. > That qom-get interface forces me to do 6 API calls to get all information! Does this really matter for an application? > > > -----Original Message----- > > From: qemu-devel-bounces+dietmar=proxmox....@nongnu.org > > [mailto:qemu-devel-bounces+dietmar=proxmox....@nongnu.org] On > > Behalf Of Luiz Capitulino > > Sent: Montag, 10. Dezember 2012 20:36 > > To: qemu-devel@nongnu.org > > Cc: aligu...@us.ibm.com; mdr...@linux.vnet.ibm.com; a...@us.ibm.com > > Subject: [Qemu-devel] [PATCH 0/3] re-enable balloon stats > > > > This new try to re-enable the virtio-balloon driver stats uses QOM > > properties > > via a polling mechanism as suggested by Anthony here: > > > > http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02390.html > > > > o Changes from the rfc > > > > - avoid balloon_stats_poll_cb() and virtio_balloon_handle_output() > > running in parallel > > - small renames and re-writes for better readability > > - update documentation > > > > Luiz Capitulino (3): > > virtio-balloon: drop old stats code > > virtio-balloon: re-enable balloon stats > > docs: document virtio-balloon stats > > > > docs/virtio-balloon-stats.txt | 87 +++++++++++++++++++ > > hw/virtio-balloon.c | 189 ++++++++++++++++++++++++++++++++++++--- > > --- > > 2 files changed, 252 insertions(+), 24 deletions(-) create mode 100644 > > docs/virtio-balloon-stats.txt > > > > -- > > 1.8.0 > > > >
