Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman

[Wenchao Xia]

于 2012-11-16 18:23, Paolo Bonzini 写道:

Il 16/11/2012 10:27, Peter Maydell ha scritto:

On 16 November 2012 05:05, Wenchao Xia <xiaw...@linux.vnet.ibm.com> wrote:

   Currently if pixman have no config.log inside, make file still
try to clean it resulting error. This patch fix it.

-       test -f pixman/config.log && make -C pixman distclean
+       @if test -f pixman/config.log; \
+       then \
+               make -C pixman distclean;\
+       fi

These two bits of shellscript both do the same thing, don't they?

No, when "test" fails the && exits with a failure.  The "if" exits with
a success (not the most portable thing ever, but we assume a decent
shell elsewhere).

I think this patch is ok, but why the "@"?

  print out seems ugly :|, maybe I should cancel @ and adjust the
format.

--
Best Regards

Wenchao Xia