Il 16/11/2012 10:27, Peter Maydell ha scritto: > On 16 November 2012 05:05, Wenchao Xia <xiaw...@linux.vnet.ibm.com> wrote: >> Currently if pixman have no config.log inside, make file still >> try to clean it resulting error. This patch fix it. >> >> - test -f pixman/config.log && make -C pixman distclean >> + @if test -f pixman/config.log; \ >> + then \ >> + make -C pixman distclean;\ >> + fi > > These two bits of shellscript both do the same thing, don't they?
No, when "test" fails the && exits with a failure. The "if" exits with a success (not the most portable thing ever, but we assume a decent shell elsewhere). I think this patch is ok, but why the "@"?
