Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Patch 3 was changed according Paolo's comments.
Patch 4-5: because qemu_opts_create can not fail while id is null, so create function qemu_opts_create_nofail and use it. Patch 6: create function qemu_opt_set_number, like qemu_opt_set_bool. Patch 7: add def_value and use it in qemu_opts_print. Patch 8: Create functions to pair with QEMUOptionParameter parser. Patch 9: Use QemuOpts parser in Block. Patch 10: Remove QEMUOptionParameter parser related code. v3->v4): 1) Rebased to the newest source tree. 2) Remove redundant "#include "block-cache.h" 3) Other small changes. v2->v3: 1) rewrite qemu_opt_set_bool and qemu_opt_set_number according Paolo's coments. 2) split patches to make review easier. v1->v2: 1) add Luiz's patches. 2) create qemu_opt_set_number() and qemu_opts_create_nofail() functions. 3) add QemuOptsList map to drivers. 4) use original opts parser, not creating new ones. 5) fix other bugs. Luiz Capitulino (2): qemu-option: opt_set(): split it up into more functions qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang (8): qemu-option: qemu_opt_set_bool(): fix code duplication introduce qemu_opts_create_nofail function use qemu_opts_create_nofail create new function: qemu_opt_set_number add def_value and use it in qemu_opts_print. Create four opts list related functions Use QemuOpts support in block layer remove QEMUOptionParameter related functions and struct block.c | 91 +++++----- block.h | 5 +- block/cow.c | 51 +++--- block/qcow.c | 64 ++++--- block/qcow2.c | 176 +++++++++--------- block/qed.c | 90 +++++----- block/raw-posix.c | 68 ++++---- block/raw.c | 31 ++- block/sheepdog.c | 80 ++++---- block/vdi.c | 73 ++++---- block/vmdk.c | 79 ++++---- block/vpc.c | 56 ++++--- block/vvfat.c | 11 +- block_int.h | 6 +- blockdev.c | 2 +- qemu-config.c | 4 +- qemu-img.c | 63 +++---- qemu-option.c | 528 +++++++++++++++++++---------------------------------- qemu-option.h | 40 +---- qemu-sockets.c | 10 +- vl.c | 12 +- 21 files changed, 692 insertions(+), 848 deletions(-)
