Il 24/10/2012 16:18, Corey Bryant ha scritto: > > > On 10/18/2012 11:15 AM, Paolo Bonzini wrote: >> Il 17/10/2012 15:15, Eduardo Otubo ha scritto: >>> With the inclusion of the new "double whitelist" seccomp filter, Qemu >>> won't be able to execve() in runtime, thus, no hotplug net devices >>> allowed. >>> >>> Signed-off-by: Eduardo Otubo <ot...@linux.vnet.ibm.com> >> >> Please check this in net_init_tap instead. When using libvirt, hotplug >> is done with a completely different mechanism that involves >> file-descriptor passing and does not require executing a helper. >> >> Paolo >> > > Are you sure net_init_tap() is the right place for this check?
Yes, assuming there is a global that says whether the seccomp sandbox is in effect. Even something like "if (sandbox_active && !tap->has_fd) error(...)" can be enough. Paolo
