On Wed, Oct 03, 2012 at 06:35:58PM -0300, Luiz Capitulino wrote:
> Has the side effect of changing the default directory used to
> save the freeze status file from /tmp to ${prefix}/var/run.
>
> This is a beneficial change for two reasons:
>
> 1. FHS states that programs must not assume that files in /tmp will
> still exist between invocations of the program. This defeats
> the purpose of the freeze status file
>
> 2. FHS dictates that /var/run must be cleaned on boot, this
> ensures that a stale freeze status file will be removed on boot
>
> Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com>
> ---
> qemu-ga.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-ga.c b/qemu-ga.c
> index b747470..daeaea5 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -40,8 +40,8 @@
> #else
> #define QGA_VIRTIO_PATH_DEFAULT "\\\\.\\Global\\org.qemu.guest_agent.0"
> #endif
> -#define QGA_PIDFILE_DEFAULT "/var/run/qemu-ga.pid"
> -#define QGA_STATEDIR_DEFAULT "/tmp"
> +#define QGA_STATEDIR_DEFAULT CONFIG_QEMU_LOCALSTATEDIR "/run"
> +#define QGA_PIDFILE_DEFAULT QGA_STATEDIR_DEFAULT "/qemu-ga.pid"
Just to confirm, in configure we have:
echo "qemu_localstatedir=$local_statedir" >> $config_host_mak
Is there some magic that generates a CONFIG_QEMU_LOCALSTATEDIR with the
same value? If so:
Reviewed-by: Michael Roth <mdr...@linux.vnet.ibm.com>
> #define QGA_SENTINEL_BYTE 0xFF
>
> struct GAState {
> --
> 1.7.12.315.g682ce8b
>
